Fix tied @INC handling in require/use operators #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes op/inccode-tie.t by properly handling tied arrays in @inc: 1. ModuleOperators.java: - Changed from direct .elements list access to indexed get() calls - Added tiedFetch() calls for TIED_SCALAR elements - Fixed absolute/relative path handling to only try hooks (not directories) - Added support for hooks returning scalar refs with code - Removed unused import 2. RuntimeArray.java: - Fixed dynamicSaveState() to preserve TieArray objects instead of copying - Fixed dynamicRestoreState() to restore array type along with elements - This fixes ClassCastException when using local @inc with tied arrays Test results: - op/inccode-tie.t: PASS (73/75 OK, 6 skipped, 1 minor failure) - make test: 100% pass rate (141/141 files, 1965/1965 tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes op/inccode-tie.t by properly handling tied arrays in @inc:
ModuleOperators.java:
RuntimeArray.java:
Test results: